Ampers - Maddie Shields#37
Open
madaleines wants to merge 14 commits intoAda-C9:masterfrom
madaleines:master
Open
Ampers - Maddie Shields#37madaleines wants to merge 14 commits intoAda-C9:masterfrom madaleines:master
madaleines wants to merge 14 commits intoAda-C9:masterfrom
madaleines:master
Conversation
API MuncherWhat We're Looking For
|
CheezItMan
reviewed
May 14, 2018
| <ul> | ||
| <% @recipes.each do |recipe| %> | ||
| <li> | ||
| <%= image_tag(recipe.image) %> |
There was a problem hiding this comment.
Making the image a clickable link would improve the user experience.
| @@ -0,0 +1,18 @@ | |||
| <h1> Results for "<%= @query %>"</h1> | |||
| <div class=""> | |||
There was a problem hiding this comment.
What purpose does this div element serve?
| end | ||
|
|
||
| describe "show_recipe" do | ||
| it "can show a single recipe" do |
There was a problem hiding this comment.
What about the negative case here? What about if the URI is wrong?
|
|
||
| class ActiveSupport::TestCase | ||
| # Setup all fixtures in test/fixtures/*.yml for all tests in alphabetical order. | ||
| fixtures :all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions